[PATCH] D23128: [Darwin] Exclude interception union tests on Darwin and Android

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 12:00:42 PDT 2016


bruno created this revision.
bruno added reviewers: rnk, etienneb.
bruno added a subscriber: llvm-commits.
Herald added subscribers: srhines, danalbert, tberghammer.

Since the directory is empty on Darwin, disable the inclusion and avoid the warning below. Exclude on Android as well to match the behavior from lib/interception/tests/CMakeLists.txt

lit.py: /Users/buildslave/jenkins/sharedspace/clang-R_master at 2/llvm/utils/lit/lit/discovery.py:224:
warning: input '/Users/buildslave/jenkins/sharedspace/clang-R_master at 2/clang-build/Build/tools/clang/runtime/compiler-rt-bins/test/interception/Unit'
contained no tests

This fixes the above warning in some of public bots, like http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/8686

https://reviews.llvm.org/D23128

Files:
  test/interception/CMakeLists.txt

Index: test/interception/CMakeLists.txt
===================================================================
--- test/interception/CMakeLists.txt
+++ test/interception/CMakeLists.txt
@@ -1,8 +1,9 @@
 set(INTERCEPTION_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
 set(INTERCEPTION_TESTSUITES)
 
-# Unit tests.
-if(COMPILER_RT_INCLUDE_TESTS)
+# Unit tests. There are currently no unit tests capable to run on Apple or
+# Android targets.
+if(COMPILER_RT_INCLUDE_TESTS AND NOT ANDROID AND NOT APPLE)
   configure_lit_site_cfg(
     ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.in
     ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23128.66685.patch
Type: text/x-patch
Size: 629 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/fb212c68/attachment.bin>


More information about the llvm-commits mailing list