[PATCH] D23102: [ADCE] Refactoring for new functionality (NFC)

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 10:29:35 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:51
@@ +50,3 @@
+  void initialize();
+  // True for operations which are always treated as live
+  bool isAlwaysLive(Instruction &);
----------------
nadav wrote:
> Please use doxygen style comments (three slashes) and a period at the end of the sentence. Please do the same for the other comments above.  
> 
> Also, please name the parameter. If the name does not give a good indication of what the parameter is you can use '\p' to describe the parameter., 
Also, just a nit, I'm used to to read `Return true for...` instead of `True for`.


https://reviews.llvm.org/D23102





More information about the llvm-commits mailing list