[PATCH] D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding

Matthias J. Reisinger via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 07:25:57 PDT 2016


mreisinger retitled this revision from "[InstCombine] Combine unfolding and optimization of casts in zext(or(icmp, icmp))" to "[InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding".
mreisinger updated the summary for this revision.
mreisinger updated this revision to Diff 66656.
mreisinger added a comment.

I now rebased the patch (I thereby also replaced my introduced `cast<>`s by `dyn_cast<>`s which is cleaner now, sorry for this post-acceptance change). I also reran `make check` and `lnt` now and the tests pass - all but the `MultiSource/Benchmarks/MiBench/consumer-typeset/consumer-typeset.execution_time` in `lnt`, but this seems to be independent from my changes since it also fails when testing with a clean llvm build that doesn't include my patch (I ran `lnt` via `myvirtualenv/bin/lnt runtest nt --sandbox /tmp --cc ~/opt/llvm_release+asserts/bin/clang --test-suite ~/repos/llvm-test-suite`). I don't know if that's a known issue, but at least I could not find an according bugzilla entry - I'll try to further investigate this.

Best,
Matthias


https://reviews.llvm.org/D22864

Files:
  lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  lib/Transforms/InstCombine/InstCombineCasts.cpp
  test/Transforms/InstCombine/zext-or-icmp.ll
  test/Transforms/InstCombine/zext.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22864.66656.patch
Type: text/x-patch
Size: 5954 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/224bff62/attachment.bin>


More information about the llvm-commits mailing list