[PATCH] D23101: Align XRay return sleds to 2 byte boundaries

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 05:14:54 PDT 2016


rSerge added inline comments.

================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1078
@@ -1077,2 +1077,3 @@
   // .Lxray_sled_N:
+  //   .palign 2, ...
   //   ret  # or equivalent instruction
----------------
Did you mean .p2align directive instead of .palign ?

================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1085
@@ -1083,2 +1084,3 @@
   OutStreamer->EmitLabel(CurSled);
+  OutStreamer->EmitCodeAlignment(4);
   unsigned OpCode = MI.getOperand(0).getImm();
----------------
Why aligning at 4 bytes? Wouldn't 2 suffice?


https://reviews.llvm.org/D23101





More information about the llvm-commits mailing list