[llvm] r277584 - [PM] Fix a mis-named parameter in parseLoopPass -- the pass manager was

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 02:14:04 PDT 2016


Author: chandlerc
Date: Wed Aug  3 04:14:03 2016
New Revision: 277584

URL: http://llvm.org/viewvc/llvm-project?rev=277584&view=rev
Log:
[PM] Fix a mis-named parameter in parseLoopPass -- the pass manager was
called "FPM" instead of "LPM" in a hold-over from when the code was
modeled on that used to parse function passes.

Modified:
    llvm/trunk/lib/Passes/PassBuilder.cpp

Modified: llvm/trunk/lib/Passes/PassBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassBuilder.cpp?rev=277584&r1=277583&r2=277584&view=diff
==============================================================================
--- llvm/trunk/lib/Passes/PassBuilder.cpp (original)
+++ llvm/trunk/lib/Passes/PassBuilder.cpp Wed Aug  3 04:14:03 2016
@@ -646,7 +646,7 @@ bool PassBuilder::parseFunctionPass(Func
   return false;
 }
 
-bool PassBuilder::parseLoopPass(LoopPassManager &FPM, const PipelineElement &E,
+bool PassBuilder::parseLoopPass(LoopPassManager &LPM, const PipelineElement &E,
                                 bool VerifyEachPass, bool DebugLogging) {
   StringRef Name = E.Name;
   auto &InnerPipeline = E.InnerPipeline;
@@ -659,7 +659,7 @@ bool PassBuilder::parseLoopPass(LoopPass
                                  DebugLogging))
         return false;
       // Add the nested pass manager with the appropriate adaptor.
-      FPM.addPass(std::move(NestedLPM));
+      LPM.addPass(std::move(NestedLPM));
       return true;
     }
     if (auto Count = parseRepeatPassName(Name)) {
@@ -667,7 +667,7 @@ bool PassBuilder::parseLoopPass(LoopPass
       if (!parseLoopPassPipeline(NestedLPM, InnerPipeline, VerifyEachPass,
                                  DebugLogging))
         return false;
-      FPM.addPass(createRepeatingPassWrapper(*Count, std::move(NestedLPM)));
+      LPM.addPass(createRepeatingPassWrapper(*Count, std::move(NestedLPM)));
       return true;
     }
     // Normal passes can't have pipelines.
@@ -677,17 +677,17 @@ bool PassBuilder::parseLoopPass(LoopPass
   // Now expand the basic registered passes from the .inc file.
 #define LOOP_PASS(NAME, CREATE_PASS)                                           \
   if (Name == NAME) {                                                          \
-    FPM.addPass(CREATE_PASS);                                                  \
+    LPM.addPass(CREATE_PASS);                                                  \
     return true;                                                               \
   }
 #define LOOP_ANALYSIS(NAME, CREATE_PASS)                                       \
   if (Name == "require<" NAME ">") {                                           \
-    FPM.addPass(RequireAnalysisPass<                                           \
+    LPM.addPass(RequireAnalysisPass<                                           \
                 std::remove_reference<decltype(CREATE_PASS)>::type>());        \
     return true;                                                               \
   }                                                                            \
   if (Name == "invalidate<" NAME ">") {                                        \
-    FPM.addPass(InvalidateAnalysisPass<                                        \
+    LPM.addPass(InvalidateAnalysisPass<                                        \
                 std::remove_reference<decltype(CREATE_PASS)>::type>());        \
     return true;                                                               \
   }




More information about the llvm-commits mailing list