[compiler-rt] r275539 - [asan] Reduce flakiness of halt_on_error-torture.cc testcase.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 23:27:30 PDT 2016


one more:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24972/steps/run%20asan%20lit%20tests%20%5Bx86%2Ffugu-userdebug%2FLMY48N%5D/logs/stdio

Testing: 0 .. 10.. 20..
FAIL: AddressSanitizer-i686-android ::
TestCases/Posix/halt_on_error-torture.cc (108 of 366)
******************** TEST 'AddressSanitizer-i686-android ::
TestCases/Posix/halt_on_error-torture.cc' FAILED ********************
Script:
--
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/android_commands/android_compile.py
 /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/bin/clang
--driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer
-fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only
--target=i686-linux-android
--sysroot=/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/../../../android-ndk/standalone-x86/sysroot
-B/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/../../../android-ndk/standalone-x86
-lm -shared-libasan -fsanitize-recover=address -pthread
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
-o /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/compiler_rt_build_android_x86/test/asan/I686AndroidConfig/TestCases/Posix/Output/halt_on_error-torture.cc.tmp
rm -f 1.txt
env ASAN_OPTIONS=halt_on_error=false:suppress_equal_pcs=false
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/compiler_rt_build_android_x86/test/asan/I686AndroidConfig/TestCases/Posix/Output/halt_on_error-torture.cc.tmp
1 10 >>1.txt 2>&1
FileCheck /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
< 1.txt
[ $(grep -c 'ERROR: AddressSanitizer: use-after-poison' 1.txt) -eq 10 ]
FileCheck --check-prefix=CHECK-NO-COLLISION
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
< 1.txt
rm -f 10.txt
env ASAN_OPTIONS=halt_on_error=false:suppress_equal_pcs=false
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/compiler_rt_build_android_x86/test/asan/I686AndroidConfig/TestCases/Posix/Output/halt_on_error-torture.cc.tmp
10 20 >>10.txt 2>&1 || true
FileCheck --check-prefix=CHECK-COLLISION
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
< 10.txt || FileCheck --check-prefix=CHECK-NO-COLLISION
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
< 10.txt
rm -f 20.txt
env ASAN_OPTIONS=halt_on_error=false
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/compiler_rt_build_android_x86/test/asan/I686AndroidConfig/TestCases/Posix/Output/halt_on_error-torture.cc.tmp
10 20 >>20.txt 2>&1 || true
FileCheck --check-prefix=CHECK-COLLISION
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
< 20.txt || FileCheck --check-prefix=CHECK-NO-COLLISION
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc
< 20.txt
--
Exit Code: 1

Command Output (stderr):
--
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc:79:22:
error: expected string not found in input
 // CHECK-COLLISION: AddressSanitizer: nested bug in the same thread, aborting
                     ^
<stdin>:1:1: note: scanning from here
=================================================================
^
<stdin>:27:10: note: possible intended match here
SUMMARY: AddressSanitizer: use-after-poison
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc:48:14
in run(void*)
         ^
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Posix/halt_on_error-torture.cc:80:25:
error: expected string not found in input
 // CHECK-NO-COLLISION: All threads terminated
                        ^
<stdin>:1:1: note: scanning from here
=================================================================
^
<stdin>:3:27: note: possible intended match here
WRITE of size 1 at 0xf5bffc60 thread T1
                          ^

--



On Mon, Aug 1, 2016 at 12:54 AM, Maxim Ostapenko <m.ostapenko at samsung.com>
wrote:

> On 22/07/16 04:13, Kostya Serebryany via llvm-commits wrote:
>
>> Do you think this is fully fixed?
>> I've seen it fail on my local machine just now (passes when I repeat)
>>
>
> Should be fixed by https://reviews.llvm.org/rL277324. Sorry for long
> delay! Please kick me again if this error still occurs.
>
> -Maxim
>
>
>> On Fri, Jul 15, 2016 at 12:57 AM, Maxim Ostapenko via llvm-commits <
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>
>>     Author: chefmax
>>     Date: Fri Jul 15 02:57:43 2016
>>     New Revision: 275539
>>
>>     URL: http://llvm.org/viewvc/llvm-project?rev=275539&view=rev
>>     Log:
>>     [asan] Reduce flakiness of halt_on_error-torture.cc testcase.
>>
>>     It seems in some situations we have clashes on very first error so
>>     test only prints "nested bug in the same thread, aborting" rather
>>     than "use-after-poison", so remove corresponding " RUN: FileCheck
>>     %s < 10.txt" line.
>>     Also, the two last " RUN: FileCheck --check-prefix=CHECK-COLLISION
>>     %s < 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s <
>>     1.txt" look wrong, they should check 10.txt. Fix these lines too.
>>
>>     Differential Revision: https://reviews.llvm.org/D22309
>>
>>     Modified:
>>     compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
>>
>>     Modified:
>>     compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
>>     URL:
>>
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc?rev=275539&r1=275538&r2=275539&view=diff
>>
>> ==============================================================================
>>     ---
>>     compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
>>     (original)
>>     +++
>>     compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
>>     Fri Jul 15 02:57:43 2016
>>     @@ -9,15 +9,11 @@
>>      //
>>      // Collisions are unlikely but still possible so we need the ||.
>>      // RUN:
>>     %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run
>>     %t 10 20 >10.txt 2>&1 || true
>>     -// This one is racy although _very_ unlikely to fail:
>>     -// RUN: FileCheck %s < 10.txt
>>     -// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt ||
>>     FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
>>     +// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt ||
>>     FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt
>>      //
>>      // Collisions are unlikely but still possible so we need the ||.
>>      // RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt
>>     2>&1 || true
>>     -// This one is racy although _very_ unlikely to fail:
>>     -// RUN: FileCheck %s < 10.txt
>>     -// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt ||
>>     FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
>>     +// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt ||
>>     FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt
>>
>>      #include <stdio.h>
>>      #include <stdlib.h>
>>
>>
>>     _______________________________________________
>>     llvm-commits mailing list
>>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160802/7a15c2b4/attachment.html>


More information about the llvm-commits mailing list