[PATCH] D23099: [compiler-rt] Fix broken interception unittest

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 19:31:53 PDT 2016


etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.

This patch is fixing a broken unittest which make the win64 bot failing.

The bug was introduce here:
  https://reviews.llvm.org/D23046

The interception code is not the same in 32-bit and in 64-bit.
The added unittest can only be patched on 32-bits.

https://reviews.llvm.org/D23099

Files:
  lib/interception/tests/interception_win_test.cc

Index: lib/interception/tests/interception_win_test.cc
===================================================================
--- lib/interception/tests/interception_win_test.cc
+++ lib/interception/tests/interception_win_test.cc
@@ -481,7 +481,11 @@
   EXPECT_TRUE(TestFunctionPatching(kPatchableCode3, override));
 #endif
   EXPECT_TRUE(TestFunctionPatching(kPatchableCode4, override));
+#if SANITIZER_WINDOWS64
+  EXPECT_FALSE(TestFunctionPatching(kPatchableCode5, override));
+#else
   EXPECT_TRUE(TestFunctionPatching(kPatchableCode5, override));
+#endif
 
   EXPECT_FALSE(TestFunctionPatching(kUnpatchableCode1, override));
   EXPECT_FALSE(TestFunctionPatching(kUnpatchableCode2, override));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23099.66608.patch
Type: text/x-patch
Size: 695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/7d2622a0/attachment.bin>


More information about the llvm-commits mailing list