[PATCH] D22724: [PM] Significantly refactor the pass pipeline parsing to be easier to reason about and less error prone.

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

Thanks for reviewing! Will land shortly.


================
Comment at: lib/Passes/PassBuilder.cpp:574
@@ +573,3 @@
+      FPM.addPass(createFunctionToLoopPassAdaptor(std::move(LPM)));
+      return true;
+    }
----------------
silvas wrote:
> Thanks for the clarification. That makes sense to me. Can you make sure that ends up in a comment somewhere (if it isn't already)?
Yea, I'll land a follow-up commit that documents some of this design stuff. Let me know if it doesn't go far enough.

================
Comment at: lib/Passes/PassBuilder.cpp:602
@@ -424,2 +601,3 @@
 
-bool PassBuilder::parseLoopPassName(LoopPassManager &FPM, StringRef Name) {
+bool PassBuilder::parseLoopPass(LoopPassManager &FPM, const PipelineElement &E,
+                                bool VerifyEachPass, bool DebugLogging) {
----------------
silvas wrote:
> `LoopPassManager &FPM` looks a bit funky. Might as well make it `LPM` if changing the line.
This is precisely one of the things I want to fix and mentioned in IRC. Changing it in this patch adds a bunch of other lines of diff sadly. I'll do it in a follow-up.


https://reviews.llvm.org/D22724