[PATCH] D23063: [ELF] - Linkerscript: implemented SUBALIGN() command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 16:04:17 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:350
@@ +349,3 @@
+  auto LocationCounter = [=]() {
+    error("access to location counter not supported for SUBALIGN");
+    return 1;
----------------
If you want to detect this error, you need to do this at parse time rather than calculation time. Being said that, I think we should just ignore the error as it complicates the code by introducing DotExpr type.


https://reviews.llvm.org/D23063





More information about the llvm-commits mailing list