[PATCH] D22742: Fix `-jobs=<N>` where <N> > 1 and the number of workers is > 1 on macOS.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 15:54:17 PDT 2016


delcypher added inline comments.

================
Comment at: lib/Fuzzer/test/fuzzer-jobs.test:1
@@ +1,2 @@
+# FIXME: Do this in a new directory to avoid the fuzz-N.log
+# files from clobbering other tests. We should allow the names
----------------
delcypher wrote:
> kcc wrote:
> > fix the FIXME
> Oops. I didn't remove the FIXME I left for myself. The implementation actually makes a temporary directory. The FIXME should actually state that doing this wouldn't be necessary if we could control the name of the fuzzing log files.
@kcc: Can I fix this in a separate commit that allows controlling the log file names? Adding a command line option to control this is independent from this patch.


https://reviews.llvm.org/D22742





More information about the llvm-commits mailing list