[PATCH] D23072: Have only one real instructionClobbersQuery

[George Burgess IV via llvm-commits]

...I need to remember to refresh my browser before reviewing things. Ignore
my "IIRC, ..." comment, please. :)

On Tue, Aug 2, 2016 at 2:51 PM, George Burgess IV <
george.burgess.iv at gmail.com> wrote:

> george.burgess.iv accepted this revision.
> george.burgess.iv added a comment.
> This revision is now accepted and ready to land.
>
> LGTM with nits. Thanks!
>
>
> ================
> Comment at: lib/Transforms/Utils/MemorySSA.cpp:141
> @@ +140,3 @@
> +      return CS.getCalledValue() == Other.CS.getCalledValue();
> +    else
> +      return Loc == Other.Loc;
> ----------------
> IIRC, this else was removed in a post-commit review? (If not, please
> remove it anyway :) )
>
> ================
> Comment at: lib/Transforms/Utils/MemorySSA.cpp:196
> @@ +195,3 @@
> +                                    AA);
> +  else
> +    return instructionClobbersQuery(MD, UseMLOC.getLoc(),
> MU->getMemoryInst(),
> ----------------
> Please remove `else`
>
>
> https://reviews.llvm.org/D23072
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160802/6452f812/attachment.html>