[PATCH] D22838: AMDGPU/SI: Implement amdgcn image intrinsics

[Changpeng Fang via llvm-commits]

cfang added inline comments.

================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:221-228
@@ -218,1 +220,10 @@
 
+class AMDGPUImageSample : Intrinsic <
+    [llvm_v4f32_ty],    // vdata(VGPR)
+    [llvm_anyint_ty,    // vaddr(VGPR)
+     llvm_v8i32_ty,     // rsrc(SGPR)
+     llvm_v4i32_ty,     // sampler(SGPR)
+     llvm_i32_ty,       // dmask(imm)
+     llvm_i32_ty],      // flags(imm)
+    [IntrNoMem]>;
+
----------------
tstellarAMD wrote:
> Moving the sample intrinsics to this file is unrelated to the AMDGPUImageLoad/AMDGPUImageStore changes, so this should be done in a separate patch.
The patch is to implement amdgcn image inttrinsics, which has three categories: AMDGPUImageLoad, AMDGPUImageStore and AMDGPUImageSample. While AMDGPUImageSample is newly defined, and the other two are modified, they do use the same mechanism, i.e. mask parameter! I think it should be better for them to be together in one patch. 


https://reviews.llvm.org/D22838