[PATCH] D22837: [NVPTX] remove unnecessary named metadata update that happens to break debug info.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 11:54:41 PDT 2016


dblaikie accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: test/CodeGen/NVPTX/generic-to-nvvm-ir.ll:49
@@ +48,3 @@
+; CHECK-SAME: scope: [[CUNODE]]
+; CHECK-SAME: variable: i8* addrspacecast (i8 addrspace(1)* @static_var to i8*)
+!5 = !DIBasicType(name: "char", size: 8, align: 8, encoding: DW_ATE_signed_char)
----------------
Is this not tested anywhere else?

================
Comment at: test/CodeGen/NVPTX/generic-to-nvvm-ir.ll:57
@@ +56,3 @@
+; CHECK: !DISubprogram
+; CHECK: unit: [[CUNODE]],
+!9 = !DISubroutineType(types: !10)
----------------
This should probably be CHECK-SAME? & maybe just check the name of the DISubprogram for good measure? (same as you did with the global variable)


https://reviews.llvm.org/D22837





More information about the llvm-commits mailing list