[PATCH] D22747: [InstCombine] try to fold (select C, (sext A), B) into logical ops

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 10:23:19 PDT 2016


spatel added inline comments.

================
Comment at: test/Transforms/InstCombine/select-bitext.ll:1
@@ +1,2 @@
+; RUN: opt < %s -instcombine -S | FileCheck %s
+
----------------
Please:
1. Remove all CHECK lines from this file.
2. Auto-generate all CHECK lines using utils/update_test_checks.py against trunk.
3. Commit the test file to trunk to show the current behavior.
4. Apply your patch locally.
5. Regenerate the CHECK lines again using the script.
6. Update this patch.

This will allow us to see the exact diffs caused by this patch.


https://reviews.llvm.org/D22747





More information about the llvm-commits mailing list