[llvm] r277485 - MSVC 2013 does not implement C++11 unions properly, so remove the anoymous union for now,

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 09:59:51 PDT 2016


Author: dannyb
Date: Tue Aug  2 11:59:51 2016
New Revision: 277485

URL: http://llvm.org/viewvc/llvm-project?rev=277485&view=rev
Log:
MSVC 2013 does not implement C++11 unions properly, so remove the anoymous union for now,
and leave a FIXME.

Modified:
    llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp

Modified: llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp?rev=277485&r1=277484&r2=277485&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp Tue Aug  2 11:59:51 2016
@@ -1118,10 +1118,10 @@ public:
   }
 
 private:
-  union {
+  // FIXME: MSVC 2013 does not properly implement C++11 union rules, once we
+  // require newer versions, this should be made an anonymous union again.
     ImmutableCallSite CS;
     MemoryLocation Loc;
-  };
 };
 
 template <> struct DenseMapInfo<MemoryLocOrCall> {




More information about the llvm-commits mailing list