[PATCH] D23047: pdbdump: Do not treat stream 0 pages as allocated pages.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 09:02:59 PDT 2016


zturner requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: tools/llvm-pdbdump/LLVMOutputStyle.cpp:315
@@ +314,3 @@
+    for (auto &S : SE)
+      if (S != 0)
+        recordKnownUsedPage(PS, S);
----------------
This isn't the correct check.  `S` here is a block number, not a stream number (Feel free to rename this to `B` if you want).  The outer loop should be written:

```
for (auto &SE : File.getStreamMap().drop_front(1))
```




https://reviews.llvm.org/D23047





More information about the llvm-commits mailing list