[PATCH] D22912: [ELF] - Linkerscript: implemented ASSERT() keyword.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:366
@@ -365,3 +365,3 @@
     auto *Cmd = dyn_cast<SymbolAssignment>(Base.get());
-    if (!Cmd || Cmd->Name == ".")
+    if (!Cmd || Cmd->Name == "." || Cmd->Name.empty())
       continue;
----------------
grimar wrote:
> ruiu wrote:
> > I didn't even look at other changes in this patch, but I think I can say the new check looks very weird. SymbolAssignment is for assignments. If it is not an assignment, you need to define a new type. Please don't give a new (obscure) meaning by defining a special case.
> Ok. Actually I was thinking about it as about expression that calculates itself but assigns to nothing.
> If you thing it should be another type, I`ll do that.
> 
> SymbolAssignment is for assignments. If it is not an assignment, you need to define a new type.
By the way, we treat PROVIDE as SymbolAssignment. I think it is also a command and not an assigment.


https://reviews.llvm.org/D22912