[PATCH] D23048: PDB: Mark extended file pages as free by default.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 19:08:33 PDT 2016


ruiu created this revision.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.

BitVector::extend initializes extended bits as true by default.
That is not desirable because new pages should be initially free.

https://reviews.llvm.org/D23048

Files:
  lib/DebugInfo/MSF/MSFBuilder.cpp

Index: lib/DebugInfo/MSF/MSFBuilder.cpp
===================================================================
--- lib/DebugInfo/MSF/MSFBuilder.cpp
+++ lib/DebugInfo/MSF/MSFBuilder.cpp
@@ -53,7 +53,7 @@
     if (!IsGrowable)
       return make_error<MSFError>(msf_error_code::insufficient_buffer,
                                   "Cannot grow the number of blocks");
-    FreeBlocks.resize(Addr + 1);
+    FreeBlocks.resize(Addr + 1, true);
   }
 
   if (!isBlockFree(Addr))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23048.66423.patch
Type: text/x-patch
Size: 474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160802/b84ad549/attachment.bin>


More information about the llvm-commits mailing list