[PATCH] D22243: [PPC] Handling CallInst in PPCBoolRetToInt

Thomas Jablin via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 16:14:01 PDT 2016


tjablin added a comment.

I believe the code is correct, but I have a few quibbles.

1. Could you add comments on lines 70 and 232 explaining why CallInsts are skipped?
2. On line 226, "There were set" => "They were set" Sorry. This was originally my typo.
3. I think most reviewers like full context for patches on phabricator. Please use one of the diff commands found here: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Thanks!


https://reviews.llvm.org/D22243





More information about the llvm-commits mailing list