[PATCH] D23022: [msf] Figure out the rest of the FPM and dump more detailed page allocation stats

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 14:07:01 PDT 2016

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.


Comment at: lib/DebugInfo/PDB/Raw/PDBFile.cpp:130
@@ +129,3 @@
+  // of 4KB (very common), this would yield 32K total blocks in file, for a
+  // maximum file size of 32K * 4K = 134MB.  Obviously this won't do, so
+  // the Fpm is split across the file at `getBlockSize()` intervals.  As a
You are mixing kilo=1000 and kilo=1024 (32K=32*1024, 4K=4*1024, but 134MB=134*1000*1000). It's more accurate to say that the total is 128MB.


More information about the llvm-commits mailing list