[compiler-rt] r277297 - XFAIL one sanitizer symbolizer test for FreeBSD

[Hans Wennborg via llvm-commits]

Go ahead (or let me know if you'd prefer me to do it).

Cheers,
Hans

On Sun, Jul 31, 2016 at 1:07 PM, Dimitry Andric <dimitry at andric.com> wrote:
> Hi Hans,
>
> I would like to merge this one to release_39, since it suppresses at least one unnecessary test failure for FreeBSD.
>
> -Dimitry
>
>> On 31 Jul 2016, at 21:27, Dimitry Andric via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: dim
>> Date: Sun Jul 31 14:27:46 2016
>> New Revision: 277297
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=277297&view=rev
>> Log:
>> XFAIL one sanitizer symbolizer test for FreeBSD
>>
>> Summary:
>> Due to a QoI issuse in FreeBSD's libcxxrt-based demangler, one sanitizer
>> symbolizer test consistently appears to fail:
>>
>>    Value of: DemangleSwiftAndCXX("foo")
>>      Actual: "float"
>>    Expected: "foo"
>>
>> This is because libcxxrt's __cxa_demangle() incorrectly demangles the "foo"
>> identifier to "float".  It should return an error instead.
>>
>> For now, XFAIL this particular test for FreeBSD, until we can fix libcxxrt
>> properly (which might take some time to coordinate with upstream).
>>
>> Reviewers: rnk, zaks.anna, emaste
>>
>> Subscribers: emaste, llvm-commits, kubabrecka
>>
>> Differential Revision: https://reviews.llvm.org/D23001
>>
>> Modified:
>>    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_symbolizer_test.cc
>>
>> Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_symbolizer_test.cc
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_symbolizer_test.cc?rev=277297&r1=277296&r2=277297&view=diff
>> ==============================================================================
>> --- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_symbolizer_test.cc (original)
>> +++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_symbolizer_test.cc Sun Jul 31 14:27:46 2016
>> @@ -62,7 +62,9 @@ TEST(Symbolizer, DemangleSwiftAndCXX) {
>>   EXPECT_STREQ("_TtSd", DemangleSwiftAndCXX("_TtSd"));
>>   // Check that the rest demangles properly.
>>   EXPECT_STREQ("f1(char*, int)", DemangleSwiftAndCXX("_Z2f1Pci"));
>> +#if !SANITIZER_FREEBSD // QoI issue with libcxxrt on FreeBSD
>>   EXPECT_STREQ("foo", DemangleSwiftAndCXX("foo"));
>> +#endif
>>   EXPECT_STREQ("", DemangleSwiftAndCXX(""));
>> }
>> #endif
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>