[PATCH] D22953: [compiler-rt] Make DemangleSwiftAndCXX robust against FreeBSD __cxa_demangle

Dimitry Andric via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 31 08:44:29 PDT 2016


dim added a comment.

In https://reviews.llvm.org/D22953#500654, @zaks.anna wrote:

> No Problem! If you do make it work, I slightly prefer this implementation since it's symmetrical with DemangleSwift.


I like the symmetry too, but on the other hand, neither DemangleCXXABI nor DemangleSwift are used anywhere outside this source file, so maybe they should be static?  And since there is already a nullptr check for the name in DemangleSwiftAndCXX, the nullptr checks in DemangleCXXABI and DemangleSwift can be removed.


https://reviews.llvm.org/D22953





More information about the llvm-commits mailing list