COFFObjectFile ignore broken symbol table

[David Majnemer via llvm-commits]

Should we make getNumberOfSymbols return 0 if there is no symbol table?

On Thu, Jul 28, 2016 at 7:46 AM, Bandzi Michal via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Hello,
>
> When binaries are compressed by UPX, information about symbol table offset
> and symbol count remain unchanged (but became invalid due to compression).
> This causes failure in constructor and rest of the binary cannot be
> processed.
>
> In proposed patch (attachment), when symbol table initialization fails,
> constructor does not return error, but rather resets symbol related
> information (symbol/string table pointers, sizes) - this should disable
> related iterators and function while rest of the binary can be processed.
>
> Michal Bandzi
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160730/b66855de/attachment.html>