[PATCH] D22120: Move inline threshold related flags to InlineSimple.cpp

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 21:25:35 PDT 2016


mehdi_amini added inline comments.

================
Comment at: include/llvm/Analysis/InlineCost.h:38
@@ +37,3 @@
+
+// Use when -O[34] is specified.
+const int OptAggressiveThreshold = 275;
----------------
davidxl wrote:
> mehdi_amini wrote:
> > davidxl wrote:
> > > mehdi_amini wrote:
> > > > There is no O4, did you mean `O{1,2,3}` here?
> > > Clang driver maps O4 to O3 (so O4 is actually 'supported').
> > Sure, but that's a clang "compatibility option" (O4 use to trigger LTO on top of O3). On the LLVM side O4 does not exist (I'm not sure it has ever existed in LLVM).
> > That said, I don't really mind if you want to add O4, but clarify the situation for O1/O2.
> ok -- this should be cleaned up then (it was in the original code that got moved here).
> 
> By the way, why deprecating O4?  It is common to use it  to turn on LTO.
I don't know exactly, all I could find was: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20130819/185217.html




https://reviews.llvm.org/D22120





More information about the llvm-commits mailing list