[PATCH] D22120: Move inline threshold related flags to InlineSimple.cpp

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 20:37:39 PDT 2016


davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm with the nit suggestion.


================
Comment at: include/llvm/Analysis/InlineCost.h:118
@@ +117,3 @@
+  /// The default threshold to start with for a callee.
+  int DefaultThreshold;
+  /// Threshold to use for callees with inline hint.
----------------
I prefer this one be called 'InlineThreshold' (to not be confused with the internal option) and document how it is set.


https://reviews.llvm.org/D22120





More information about the llvm-commits mailing list