[PATCH] D22987: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 17:16:17 PDT 2016


vsk created this revision.
vsk added reviewers: zturner, spyffe, clayborg.
vsk added a subscriber: llvm-commits.

It's pulling in all kinds of unused things (e.g, at this time of
writing, clang-tidy!). This needlessly slows down every build of lldb.

This passes check-lldb.



https://reviews.llvm.org/D22987

Files:
  cmake/modules/AddLLDB.cmake

Index: cmake/modules/AddLLDB.cmake
===================================================================
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -84,11 +84,6 @@
     endif()
   endif()
 
-  # Hack: only some LLDB libraries depend on the clang autogenerated headers,
-  # but it is simple enough to make all of LLDB depend on some of those
-  # headers without negatively impacting much of anything.
-  add_dependencies(${name} libclang)
-
   set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
 endmacro(add_lldb_library)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22987.66205.patch
Type: text/x-patch
Size: 563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160730/6f052bbb/attachment.bin>


More information about the llvm-commits mailing list