[PATCH] D22966: GVN-hoist: compute MSSA once per function (PR28670)

[Daniel Berlin via llvm-commits]

dberlin added a comment.

Oh, i see what you are trying to do.

MemorySSA is not actually part of the IR right now, so you can't use moveBefore :(
It has it's own access lists, etc.

As you say, it would not be enough to simply to change what it stores, there are places we keep the BB.

For now, the right thing to do is to call removeAccess on the instruction, call moveBefore on the IR, then createMemoryAccessAfter <hoistpt's memoryaccess>.

The real solution to making this not messy would be to make MemorySSA part of the IR.

I will push for that.


https://reviews.llvm.org/D22966