[PATCH] D22120: Move inline threshold related flags to InlineSimple.cpp

[Xinliang David Li via llvm-commits]

On Fri, Jul 29, 2016 at 3:18 PM, Easwaran Raman <eraman at google.com> wrote:
> eraman marked 3 inline comments as done.
>
> ================
> Comment at: include/llvm/Analysis/InlineCost.h:132
> @@ -112,3 +131,3 @@
>  /// inlining the callsite. It is an expensive, heavyweight call.
>  InlineCost getInlineCost(CallSite CS, int DefaultThreshold,
>                           TargetTransformInfo &CalleeTTI,
> ----------------
> davidxl wrote:
>> Should defaultThreshold be wrapped in inline-params too?
>>
>> Edit: probably not. The defaultThreshold here means many different things (opt level specific default when default-threshold option is not specified, threshold passed in API, or indirect call threshold etc.) -- I hope this can be cleaned up at some point:  cost analysis should just look at the InlineParams to make decisions.
> I actually think it should be moved to InlineParams. It is computed by different means, but the meaning is the same - use this threshold in the absence of any other overrides. If you agree I'll move this as well.

If it can be done in a clean way, it is certainly welcome ;)

David


>
>
> https://reviews.llvm.org/D22120
>
>
>