[PATCH] D22120: Move inline threshold related flags to InlineSimple.cpp

[Easwaran Raman via llvm-commits]

On Fri, Jul 22, 2016 at 3:43 PM, Xinliang David Li <davidxl at google.com>
wrote:

>
>
> On Fri, Jul 22, 2016 at 3:39 PM, Easwaran Raman <eraman at google.com> wrote:
>
>> eraman added a comment.
>>
>> Well, in that case, you need to create a separate entry point that
>> doesn't override the passed threshold. The behavior of
>> createFunctionInliningPass should remain unchanged. Consider -O3 for
>> example. What should happen if you pass -O3 and -inline-threshold=1000 ?
>>
>>
> I think a more generic creator interface that takes optlevel should be
> introduced (matching the constructor) and used.
>

I don't quite follow this comment, but from our offline discussion I got
the impression that this patch is on the right direction.


> David
>
>
>>
>> https://reviews.llvm.org/D22120
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/c803a8a7/attachment.html>