[PATCH] D22639: Add flag to PassManagerBuilder to disable GVN Hoist Pass.

[Daniel Berlin via llvm-commits]

yeah.

opt -gvn-hoist definitely works.

-O1/-O2 already requires various flags/not flags to enable  passes, so this
is no different (-enable-load-pre is an example)


On Fri, Jul 29, 2016 at 9:19 AM, Hans Wennborg <hans at chromium.org> wrote:

> hans added a comment.
>
> In https://reviews.llvm.org/D22639#500689, @probinson wrote:
>
> > This means to enable the pass in opt I need to do both
> `-enable-gvn-hoist` and `-O1` which is not usual for opt.  (For example I
> need just `-dce` to get DCE.)  Is that the intent?
>
>
> I thought opt didn't use PassManagerBuilder, but added passes through some
> other magic. I don't actually know that this is how it works, but I assumed
> it was something like it, because test/Transforms/GVN/hoist.ll still just
> runs "opt -gvn-hoist" and it seems to work.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D22639
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/ecc9525f/attachment.html>