[PATCH] D22820: [GlobalISel] improved interface to MachineIRBuilder::buildInstr

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 09:20:26 PDT 2016


tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added a comment.

In https://reviews.llvm.org/D22820#497728, @ab wrote:

> It does seem nicer!
>
> Here's a simpler alternative: have buildInstr return the builder, and replace addReg with explicit addDef/addUse?  That spares you the template hackery for a similar result. WDYT?


I also like this idea, because it makes it really easy to add immediate operands.


Repository:
  rL LLVM

https://reviews.llvm.org/D22820





More information about the llvm-commits mailing list