[PATCH] D22683: [ELF] Symbol assignment within input section list

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 09:13:55 PDT 2016


rafael added inline comments.

================
Comment at: ELF/LinkerScript.cpp:147
@@ +146,3 @@
+      std::unique_ptr<SymbolInputSection<ELFT>> SymSec(
+          new SymbolInputSection<ELFT>(Assignment));
+      Current->addSection(SymSec.get());
----------------
Sorry, it is not clear why you need a new section type, it looks like you can always assign the symbol to an existing input or output section, no?

The general case you will have something like

foo_and_bar : {
  begin_foo = .; *(.foo*) end_foo = .;
  begin_bar = .; *(.bar*); end_bar = .;
 }

If there is any input section following a symbol, associate the symbol with the input section with an offset of 0.
If there is no input section following a symbol, associate the symbol with the end of the output section.



Repository:
  rL LLVM

https://reviews.llvm.org/D22683





More information about the llvm-commits mailing list