[PATCH] D22912: [ELF] - Linkerscript: implemented ASSERT() keyword.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:366
@@ -365,3 +365,3 @@
     auto *Cmd = dyn_cast<SymbolAssignment>(Base.get());
-    if (!Cmd || Cmd->Name == ".")
+    if (!Cmd || Cmd->Name == "." || Cmd->Name.empty())
       continue;
----------------
I didn't even look at other changes in this patch, but I think I can say the new check looks very weird. SymbolAssignment is for assignments. If it is not an assignment, you need to define a new type. Please don't give a new (obscure) meaning by defining a special case.


https://reviews.llvm.org/D22912