[PATCH] D22962: [ELF] - Linkerscript cleanup of LinkerScript<ELFT>::createSections()

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 07:41:09 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with one change.


================
Comment at: ELF/LinkerScript.cpp:135
@@ +134,3 @@
+    for (const std::unique_ptr<BaseCommand> &Cmd : P.second) {
+      auto *InCmd = dyn_cast<InputSectionDescription>(Cmd.get());
+      if (!InCmd)
----------------
Please keep the filter in getSectionMap for now.


https://reviews.llvm.org/D22962





More information about the llvm-commits mailing list