[PATCH] D22749: [ELF] - Linkerscript: Implemented SORT command

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:119
@@ +118,3 @@
+template <class ELFT>
+static void addSection(OutputSectionFactory<ELFT> &Factory,
+                       std::vector<OutputSectionBase<ELFT> *> &Out,
----------------
rafael wrote:
> Can you commit making this a static function as an independent cleanup?
This probably intersects with getSectionMap() change, so it probably be a single cleanup patch. Looking.

================
Comment at: ELF/LinkerScript.cpp:147
@@ -146,1 +146,3 @@
+      auto *InCmd = dyn_cast<InputSectionDescription>(Cmd.get());
+      if (!InCmd)
         continue;
----------------
rafael wrote:
> Maybe getSectionMap should do this filtering?
For this patch this probably be fine, though generally we can need another commands afaik.
Let me quickly prepare separate cleanup patch(s) with this and other changes.


https://reviews.llvm.org/D22749