[llvm] r277066 - range

[Vitaly Buka via llvm-commits]

The reason "Should be committed as one CL." is on the commit message.
I agree that reply to original commits could be helpful.


On Thu, Jul 28, 2016 at 5:29 PM Davide Italiano <davide at freebsd.org> wrote:

> On Thu, Jul 28, 2016 at 5:18 PM, Vitaly Buka via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > By mistake I committed several temporarily git CLs from my local branch.
> It
> > is already reverted.
> >
>
> When a commit is reverted, the commit that reverts should mention the
> revision reverted (I might have missed it, but I don't see it), e.g.
> "Revert r6666666 because it breaks the bots).
> You can also (or in alternative) reply to your original commit saying
> that this was reverted so that people don't have to search through the
> lists.
>
> --
> Davide
>
> >
> > On Thu, Jul 28, 2016 at 5:14 PM David Majnemer <david.majnemer at gmail.com
> >
> > wrote:
> >>
> >> This commit message isn't very enlightening.  What's going on?
> >> Please strive for commit messages which are more descriptive.
> >>
> >> On Thu, Jul 28, 2016 at 6:50 PM, Vitaly Buka via llvm-commits
> >> <llvm-commits at lists.llvm.org> wrote:
> >>>
> >>> Author: vitalybuka
> >>> Date: Thu Jul 28 17:50:43 2016
> >>> New Revision: 277066
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=277066&view=rev
> >>> Log:
> >>> range
> >>>
> >>> Modified:
> >>>     llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
> >>>
> >>> Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
> >>> URL:
> >>>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp?rev=277066&r1=277065&r2=277066&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
> (original)
> >>> +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp Thu Jul
> 28
> >>> 17:50:43 2016
> >>> @@ -30,6 +30,8 @@ using namespace PatternMatch;
> >>>
> >>>  STATISTIC(NumSimplified, "Number of library calls simplified");
> >>>
> >>> +extern cl::opt<bool> ClUseAfterScope;
> >>> +
> >>>  /// Return the specified type promoted as it would be to pass though a
> >>> va_arg
> >>>  /// area.
> >>>  static Type *getPromotedType(Type *Ty) {
> >>> @@ -1209,6 +1211,10 @@ static bool removeTriviallyEmptyRange(In
> >>>                                        unsigned EndID, InstCombiner
> &IC)
> >>> {
> >>>    assert(I.getIntrinsicID() == StartID &&
> >>>           "Start intrinsic does not have expected ID");
> >>> +  // Even if the range is empty asan need to poison memory to detect
> >>> invalid
> >>> +  // access latter.
> >>> +  if (ClUseAfterScope)
> >>> +    return false;
> >>>    BasicBlock::iterator BI(I), BE(I.getParent()->end());
> >>>    for (++BI; BI != BE; ++BI) {
> >>>      if (auto *E = dyn_cast<IntrinsicInst>(BI)) {
> >>>
> >>>
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at lists.llvm.org
> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >>
> >>
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/4d0e1559/attachment.html>