[PATCH] D22852: [ELF] - Linkerscript: implemented filename specification.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/LinkerScript.cpp:700
@@ +699,3 @@
+std::unique_ptr<InputSectionDescription> ScriptParser::readInputSectionDescription() {
+  std::unique_ptr<InputSectionDescription> InCmd = std::make_unique<InputSectionDescription>();
+
----------------
Use `auto`.

================
Comment at: ELF/LinkerScript.cpp:708-710
@@ +707,5 @@
+    expect(")");
+  }
+  else
+    readInputSectionRules(InCmd.get(), false);
+
----------------
  } else {
    readInpu... 
  }

================
Comment at: ELF/LinkerScript.cpp:750-752
@@ +749,5 @@
+    if ((!peek().empty() && peek()[0] == '*') || peek() == "KEEP") {
+      std::unique_ptr<InputSectionDescription> InCmd =
+          readInputSectionDescription();
+      Cmd->Commands.push_back(std::move(InCmd));
+      continue;
----------------
  Cmd->Command.push_back(readInputSectionDescription());


https://reviews.llvm.org/D22852