[PATCH] D22916: [ELF] - Linkerscript: implemented += operator.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:922-923
@@ -918,3 +921,4 @@
   if (Tok.getAsInteger(0, V)) {
-    if (!isValidCIdentifier(Tok))
+    if (Tok != "." && !isValidCIdentifier(Tok))
       setError("malformed number: " + Tok);
+    return [=](uint64_t Dot) { return getSymbolValue(Tok, Dot); };
----------------
I think you can remove this error check. If Tok is not a valid symbol name, getSymbolValue will find it.


https://reviews.llvm.org/D22916