[PATCH] D22858: Fix DbgValue handling in SelectionDAG.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 13:11:03 PDT 2016


hans added a comment.

In https://reviews.llvm.org/D22858#499623, @niravd wrote:

> My attempts at reproducing the bug from PR28749 have failed so I can't tell if TransferDbgValue is sufficient to fix this.


PR28749 reproduces reliably for me (I tried on the 3.9 branch, but I assume it's the same on trunk).

> In the interests of resolving this quickly I'm going to commit just that as it's fixing a clear mistake and will leave this patch open to discuss the remainder of this patch.


IIUC, you committed that in r277027. However, that doesn't fix PR28749 for me. Applying the full patch from this review does make the error go away though, so it seems to be doing the right thing :-)


https://reviews.llvm.org/D22858





More information about the llvm-commits mailing list