[PATCH] D22811: [ELF] Linkerscript: allow setting custom output section for common symbols, instead of .bss

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.

================
Comment at: ELF/Writer.cpp:741
@@ +740,3 @@
+  // then add it to .bss now.
+  if (!CommonSection->OutSec && CommonSection->getSize()) {
+    Out<ELFT>::Bss->addSection(CommonSection.get());
----------------
ruiu wrote:
> Remove the size check if not necessary.
Looks like this check is really not necessary. After removing it I had to add this->Live = true to CommonInputSection constructor to make tests pass when --gc-sections flag is set.


https://reviews.llvm.org/D22811