[PATCH] D22353: FileCheck Enhancement - CHECK-WORD

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 11:18:27 PDT 2016


aprantl added a comment.

I don't think making this the default behavior is a good idea. This may introduce hard-to-find bugs to every testcase (because they were written written with the old behavior in mind).
For example, how would we even find problems with CHECK-NOT; the new behavior will make the expressions stricter, but we wouldn't even realize it because we're expecting no match. The only way this could be made the default behavior would be to change all existing CHECKs to explicitly use the old behavior. This would still break every out-of-tree testcase, but that is admittedly a lesser concern.


https://reviews.llvm.org/D22353





More information about the llvm-commits mailing list