[PATCH] D19475: [mips] Clang generates unaligned offset for MSA instruction st.d

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 08:05:51 PDT 2016


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a nit


================
Comment at: lib/Target/Mips/MipsSEISelDAGToDAG.cpp:311
@@ +310,3 @@
+        // eliminateFrameIndex, otherwise we need to check the alignment
+        if (OffsetToAlignment(CN->getZExtValue(), 1 << ShiftAmount))
+          return false;
----------------
Please add a '!= 0' to make the intent of the check more obvious


https://reviews.llvm.org/D19475





More information about the llvm-commits mailing list