[PATCH] D22911: [compiler-rt][XRay] Address follow-up comments to initial interface and initialisation code

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 03:59:43 PDT 2016


dberris created this revision.
dberris added reviewers: eugenis, rnk, kcc, echristo, majnemer.
dberris added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

This addresses some comments from D21612, which contains the following changes:

- Update __xray_patch() and __xray_unpatch() API documentation to not imply asynchrony.
- Introduce a scope cleanup mechanism to make sure we can roll-back changes to the XRayPatching global atomic.
- Introduce a few more comments for potential extension points for other platforms (for the implementation details of patching and un-patching).

https://reviews.llvm.org/D22911

Files:
  include/xray/xray_interface.h
  lib/xray/xray_init.cc
  lib/xray/xray_interface.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22911.65905.patch
Type: text/x-patch
Size: 6335 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160728/d19459ed/attachment.bin>


More information about the llvm-commits mailing list