[PATCH] D22749: [ELF] - Linkerscript: Implemented SORT command

[George Rimar via llvm-commits]

grimar added a comment.

By the way, if we create bool Keep field in InputSectionDescription,
that can help to remove the Keep argument from few methods.
I know that Keep is not used after parcing since we have a separate array for keeped sections, but probably that
make code a bit cleaner and can worth that little field.


================
Comment at: ELF/LinkerScript.h:137
@@ -135,3 +136,3 @@
 private:
-  std::vector<std::pair<StringRef, const InputSectionDescription *>>
+  std::vector<std::pair<StringRef, std::vector<const BaseCommand *>>>
   getSectionMap();
----------------
ruiu wrote:
> ArrayRef?
Ok. Though it is ArrayRef<std:unique_ptr<...>> then. I am not sure why,
but I feel it is a bit strange combination.


https://reviews.llvm.org/D22749