[llvm] r276969 - Remove two tests added in r276957.

Daniel Jasper via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 02:54:35 PDT 2016


Author: djasper
Date: Thu Jul 28 04:54:35 2016
New Revision: 276969

URL: http://llvm.org/viewvc/llvm-project?rev=276969&view=rev
Log:
Remove two tests added in r276957.

These loop from 0 to AEK_XSCALE, which is currently defined as 0x80000000, and
thus the tests loop over the entire int range, which is unreasonable
and also too slow in debug builds.

Modified:
    llvm/trunk/unittests/Support/TargetParserTest.cpp

Modified: llvm/trunk/unittests/Support/TargetParserTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/TargetParserTest.cpp?rev=276969&r1=276968&r2=276969&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/TargetParserTest.cpp (original)
+++ llvm/trunk/unittests/Support/TargetParserTest.cpp Thu Jul 28 04:54:35 2016
@@ -213,15 +213,6 @@ TEST(TargetParserTest, ARMArchAttr) {
                     : (kARMARCHNames[AK].ArchAttr == ARM::getArchAttr(AK)));
 }
 
-TEST(TargetParserTest, ARMArchExtName) {
-  for (ARM::ArchExtKind AEK = static_cast<ARM::ArchExtKind>(0);
-       AEK <= ARM::ArchExtKind::AEK_XSCALE;
-       AEK = static_cast<ARM::ArchExtKind>(static_cast<unsigned>(AEK) + 1))
-    EXPECT_TRUE(contains(kARMArchExtKinds, static_cast<unsigned>(AEK))
-                    ? !ARM::getArchExtName(AEK).empty()
-                    : ARM::getArchExtName(AEK).empty());
-}
-
 TEST(TargetParserTest, ARMArchExtFeature) {
   const char *ArchExt[][4] = {{"crc", "nocrc", "+crc", "-crc"},
                               {"crypto", "nocrypto", "+crypto", "-crypto"},
@@ -246,15 +237,6 @@ TEST(TargetParserTest, ARMArchExtFeature
   }
 }
 
-TEST(TargetParserTest, ARMHWDivName) {
-  for (ARM::ArchExtKind AEK = static_cast<ARM::ArchExtKind>(0);
-       AEK <= ARM::ArchExtKind::AEK_XSCALE;
-       AEK = static_cast<ARM::ArchExtKind>(static_cast<unsigned>(AEK) + 1))
-    EXPECT_TRUE(contains(kHWDivKinds, static_cast<unsigned>(AEK))
-                    ? !ARM::getHWDivName(AEK).empty()
-                    : ARM::getHWDivName(AEK).empty());
-}
-
 TEST(TargetParserTest, ARMDefaultCPU) {
   for (unsigned i = 0; i < array_lengthof(ARMArch); i++)
     EXPECT_FALSE(ARM::getDefaultCPU(ARMArch[i]).empty());




More information about the llvm-commits mailing list