[PATCH] D22890: AArch64: Add missing branch relaxation tests

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 01:26:57 PDT 2016


rovka added a subscriber: rovka.
rovka accepted this revision.
rovka added a reviewer: rovka.
rovka added a comment.
This revision is now accepted and ready to land.

Thanks for working on this. Could you please rename the test files to branch-relax-blah.ll? (To match the already-existing branch-relax-asm.ll).


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:134
@@ +133,3 @@
+  // Verify the displacement bits options have sane values.
+  // XXX: Is there a better place for this?
+  assert(MaxOffs >= 8 &&
----------------
I'd rather move this closer to the point of use, because that would make the need for it clearer. But that's just personal preference.


https://reviews.llvm.org/D22890





More information about the llvm-commits mailing list