[PATCH] D22870: [AArch64] Return the correct size for TLSDESC_CALLSEQ

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 00:05:21 PDT 2016


rovka added inline comments.

================
Comment at: test/CodeGen/MIR/AArch64/inst-size-tlsdesc-callseq.mir:27-28
@@ +26,4 @@
+# If the size of TLSDESC_CALLSEQ is computed correctly, that will push
+# the bb.2.false block too far away from the TBNZW, so the branch will
+# have to be relaxed.
+# CHECK: TBZW killed %w0, 0, %bb.1.true
----------------
t.p.northover wrote:
> Could you reiterate that you're using aarch64-tbz-offset-bits here. I was thoroughly confused, and spent 5 minutes looking for the massive space-consuming instruction below.
Sorry about that! I'll fix it before I commit, thanks for reviewing.


https://reviews.llvm.org/D22870





More information about the llvm-commits mailing list