[PATCH] D22888: Add verifyAnalysis for LCSSA.

[Michael Zolotukhin via llvm-commits]

mzolotukhin added inline comments.

================
Comment at: lib/Transforms/Utils/LCSSA.cpp:318
@@ -317,1 +317,3 @@
   bool runOnFunction(Function &F) override;
+  void verifyAnalysis() const override {
+    assert(
----------------
sanjoy wrote:
> I'm missing something here -- how is LCSSA an "analysis" that can be "verified"?
I'm not very confident about this, but my understanding was that if a pass states that it preserves LCSSA (`AU.addPreservedID(LCSSAID)` like e.g. LoopSimplify does), then pass manager would run `verifyAnalysis` for `LCSSA`. In debugger this function is definitely entered several times.

I'd be happy to be corrected here, and add a verifier in some other way.


https://reviews.llvm.org/D22888