[PATCH] D22811: [ELF] Linkerscript: allow setting custom output section for common symbols, instead of .bss

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Symbols.h:188
@@ -187,1 +187,3 @@
+  // Output section for this symbol (default is .bss)
+  OutputSectionBase<ELFT> *Section = nullptr;
 };
----------------
evgeny777 wrote:
> ruiu wrote:
> > You can remove this variable, no?
> So you suggest to replace it with pointer to CommonInputSection and use OutSec and OutSecOff, correct?
Yes. Or, more radially, you can make a pointer to a CommonInputSection a global varaible since it's a singleton class, but it's probably too much for this change, so I wouldn't do it at least now.


https://reviews.llvm.org/D22811