[PATCH] D22491: Added ThinLTO inlining statistics

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 14:05:15 PDT 2016


Prazek added a comment.

In https://reviews.llvm.org/D22491#498228, @tejohnson wrote:

> Couple minor comments on the comments, but otherwise looks ok. I'm not convinced the complexity of the new handling in recordInlineto avoid the extra map lookup is necessary since this is just stat counting code not on by default though, but I don't have a strong objection to it either.


I trieid different code with insert/emplace etc, and it was even uglier. The 2 step indirection is the bad guy here, but at least 1 lookup and 1 allocation is the good guy


https://reviews.llvm.org/D22491





More information about the llvm-commits mailing list